Revert "Include Swift Build support in second stage bootstrap builds" #8366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
MaxDesiatov,
bkhouri,
bnbarham,
bripeticca,
dschaefer2,
jakepetroules,
plemarquand,
shawnhyam and
xedin
as code owners
Contributor
Author
|
@swift-ci test |
plemarquand
added a commit
to plemarquand/swift-package-manager
that referenced
this pull request
Mar 13, 2025
swiftlang#8366 is a revert, but it reverted back to a point before there was an outer `withService` block wrapping the code. As a result a `self` was missing on `buildParameters`, causing a build failure.
plemarquand
added a commit
that referenced
this pull request
Mar 13, 2025
#8366 is a revert, but it reverted back to a point before there was an outer `withService` block wrapping the code. As a result a `self` is missing on `buildParameters`, causing a build failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8334
This seems to cause an issue in the incremental buildbots